Simplify config data #2052
Merged
Simplify config data #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 8, 2025
| } | ||
|
|
||
| @Override | ||
| protected KubernetesNamespaceProvider kubernetesNamespaceProvider(Environment environment) { |
There was a problem hiding this comment.
not removed, it is part of the super class now
wind57
commented
Oct 8, 2025
| /** | ||
| * @author Ryan Baxter | ||
| */ | ||
| public final class KubernetesConfigDataResource extends ConfigDataResource { |
There was a problem hiding this comment.
this used to be in a different package with many more fields (that we were not using). So what I did:
- remove all the fields that we make no use of
- move it to a dedicate package
wind57
commented
Oct 8, 2025
| */ | ||
| public abstract class KubernetesConfigDataLocationResolver | ||
| implements ConfigDataLocationResolver<KubernetesConfigDataResource>, Ordered { | ||
|
|
There was a problem hiding this comment.
this class already existed in a different package, I moved it in a different package.
Also, I transferred some code from it to ConfigDataPropertiesHolder
wind57
commented
Oct 8, 2025
| /** | ||
| * @author wind57 | ||
| */ | ||
| public record ConfigDataPropertiesHolder(KubernetesClientProperties clientProperties, |
There was a problem hiding this comment.
this code already existed in a separate class, but I wanted to have a single entry point where we would look that deals with properties registration.
Signed-off-by: wind57 <[email protected]>
|
@ryanjbaxter ready for review. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.