Clean up after breaking changes #2060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
…nce' into clean-up-after-breaking-changes
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 11, 2025
| @Override | ||
| protected void registerBeans(ConfigDataLocationResolverContext resolverContext, ConfigDataLocation location, | ||
| Profiles profiles, ConfigDataPropertiesHolder properties, KubernetesNamespaceProvider namespaceProvider) { | ||
| protected void registerBeans(ConfigDataLocationResolverContext resolverContext, |
There was a problem hiding this comment.
we were not using two arguments, so I removed them
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
|
@ryanjbaxter some clean-up after all those breaking changes. thank you |
|
Awesome, we are going to do our release next week. Are we towards the end of the breaking changes? |
|
Im done with everything I had in my queue |
|
Awesome! I really appreciate all the hard work! Thanks! |
|
I'll see if I make also this one in time, but I don't have a PR even in draft mode ready, so let's see. |
|
it turns out, I would very much like to have around 8 / 10 PRs to go in |
|
We will see. We have to do it this week, so there is not much wiggle room. |
|
I perfectly understand that, and I have also no doubt that we will make it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.