fix-1641: serialization concerns (1) #2062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
wind57
commented
Oct 11, 2025
| } | ||
|
|
||
| @Override | ||
| @Cacheable("serviceinstances") |
There was a problem hiding this comment.
I think we should start with all services being non-cacheable and I will work in reverse, to add cacheable separate clients.
Removing this option is a breaking change, but adding separate clients on top, would be not.
There was a problem hiding this comment.
Lets separate removing the cachable annotations into its own PR to keep things a bit cleaner
|
@ryanjbaxter this is part-1 of some other PRs that will eventually close issue 1641. I will let you know when that issue is completely covered. This is now ready to be looked at, thank you. |
wind57
changed the title
Signed-off-by: wind57 <[email protected]>
Signed-off-by: wind57 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.