Adds ignorecase field to pageable spring #1047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dlerMethodArgumentResolverSupport::parseIgnoreCase
OlgaMaciaszek
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Hi, @gklp. Thanks for submitting the PR. Have added some cosmetic comments - please address them. Also, please update the date in the license comments of any files you've modified to 2013-2024 .
...e/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java
Outdated
Show resolved
Hide resolved
...e/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java
Outdated
Show resolved
Hide resolved
OlgaMaciaszek
added
enhancement
|
all issues were resolved @OlgaMaciaszek |
OlgaMaciaszek
requested changes
Sep 12, 2024
There was a problem hiding this comment.
Hi @gklp, it still needs one minor change - please see the comment.
...e/src/test/java/org/springframework/cloud/openfeign/encoding/FeignPageableEncodingTests.java
Outdated
Show resolved
Hide resolved
OlgaMaciaszek
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ignorecase field to pageable spring for compatibility with SortHandlerMethodArgumentResolverSupport::parseIgnoreCase