Replace deprecated URL constructor in getUrl #1179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rning The constructor 'URL(String)' has been deprecated since Java 20. Although this does not affect the current environment (Java 17), it will cause issues when upgrading to Java 21 or later. This commit updates the URL validation in FeignClientsRegistrar.getUrl by replacing `new URL(url)` with `new URI(url)`, ensuring forward compatibility. Verified with Java 17 and the FeignClientsRegistrarTests. Signed-off-by: HyeongDo-Myeong <[email protected]>
HyeongDo-Myeong
force-pushed
the
fix-url-validation
branch
from
c6ab115 to
ba824fa
Compare
OlgaMaciaszek
requested changes
May 7, 2025
There was a problem hiding this comment.
Hello @HyeongDo-Myeong, thanks for submitting the PR. Looks good. Please update the date in the license comments on top of all the java classes you've changed to -2025. Also, please add the @author tag with your full name and surname to the javadocs of the classes you've modified.
Updated license headers to reflect year 2025 in all modified Java files. Also added @author Javadoc tags with full name to classes modified in the previous commit as requested in PR review. Signed-off-by: HyeongDo-Myeong <[email protected]>
HyeongDo-Myeong
force-pushed
the
fix-url-validation
branch
from
dd85e42 to
755557d
Compare
|
@OlgaMaciaszek Thank you for the review. I've updated the license headers to reflect 2025 and added the author tags as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor 'URL(String)' has been deprecated since Java 20. Although this does not affect the current environment (Java 17), it will cause issues when upgrading to Java 21 or later. This commit updates the URL validation in FeignClientsRegistrar.getUrl by replacing
new URL(url)withnew URI(url), ensuring forward compatibility.Additionally, tests were added to verify both valid and malformed URL scenarios:
Verified with Java 17 and the FeignClientsRegistrarTests.