Skip to content

Replace Collectors.toList() with Stream.toList() #1746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eunseo9311 wants to merge 1 commit into from
Closed

Replace Collectors.toList() with Stream.toList() #1746

eunseo9311 wants to merge 1 commit into from

Conversation

@eunseo9311
Copy link
Contributor

@eunseo9311 eunseo9311 commented Jan 23, 2026

Title:
Replace Collectors.toList() with Stream.toList()

Description:

Summary

Modernize stream collection operations by replacing Collectors.toList() with Stream.toList() introduced in Java 16.

Changes

  • InitializrMetadataV2JsonMapper.java: 3 occurrences
  • DependenciesCapability.java: 1 occurrence
  • Removed unused Collectors import statements

Motivation

  1. Conciseness: stream.toList() is shorter and more readable
  2. Performance: Avoids creating an intermediate Collector object
  3. Immutability: toList() returns an unmodifiable list, which aligns with existing usage patterns
  4. Modern Java: Aligns with Java 16+ idioms since the project requires Java 17

@eunseo9311
Replace Collectors.toList() with Stream.toList()
d4bcb73 
Use the more concise Stream.toList() method introduced in Java 16
instead of Collectors.toList() for better readability and slight
performance improvement.

Signed-off-by: Eunseo Song <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 23, 2026
@mhalbritter
Copy link
Contributor

mhalbritter commented Jan 26, 2026

Hello! What is the relation to #1747? Could the changes from this PR be included in #1747 or vice versa?

@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Jan 26, 2026
@eunseo9311
Copy link
Contributor Author

eunseo9311 commented Jan 27, 2026

Hi! PR #1747 now includes all changes from this PR plus additional files with the same refactoring (19 files total). Closing this in favor of #1747.

@eunseo9311 eunseo9311 closed this Jan 27, 2026
@mhalbritter mhalbritter added status: superseded and removed status: waiting-for-feedback We need additional information before we can continue status: waiting-for-triage An issue we've not yet triaged labels Jan 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: superseded

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eunseo9311 @mhalbritter @spring-projects-issues