Skip to content

Minor update to RelevancyEvaluator, simplify checks and filtering #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Minor update to RelevancyEvaluator, simplify checks and filtering #1390

wants to merge 1 commit into from

Conversation

@alexcheng1982
Copy link
Contributor

Return type of Content.getContent is already String, no need for type checking and toString. Use StringUtils.hasText to filter out null or empty strings.

@alexcheng1982
Minor update, simplify checks and filtering
eda1bcd 
Return type of `getContent` is already `String`, no need for type checking and toString
@markpollack
Copy link
Member

thanks! merged in 2ecffc1

@markpollack markpollack added this to the 1.0.0-M3 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Evaluation

Projects

None yet

Milestone

1.0.0-M3

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcheng1982 @markpollack