Skip to content

Add Meta Llama 3.1, 3.2 instruct model enums to Bedrock #1419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Meta Llama 3.1, 3.2 instruct model enums to Bedrock #1419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion ...i-bedrock/src/main/java/org/springframework/ai/bedrock/llama/api/LlamaChatBedrockApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,42 @@ public enum LlamaChatModel implements ChatModelDescription {
/**
* meta.llama3-70b-instruct-v1:0
*/
LLAMA3_70B_INSTRUCT_V1("meta.llama3-70b-instruct-v1:0");
LLAMA3_70B_INSTRUCT_V1("meta.llama3-70b-instruct-v1:0"),

/**
* meta.llama3-1-8b-instruct-v1:0
*/
LLAMA3_1_8B_INSTRUCT_V1("meta.llama3-1-8b-instruct-v1:0"),

/**
* meta.llama3-1-70b-instruct-v1:0
*/
LLAMA3_1_70B_INSTRUCT_V1("meta.llama3-1-70b-instruct-v1:0"),

/**
* meta.llama3-1-405b-instruct-v1:0
*/
LLAMA3_1_405B_INSTRUCT_V1("meta.llama3-1-405b-instruct-v1:0"),

/**
* meta.llama3-2-1b-instruct-v1:0
*/
LLAMA3_2_1B_INSTRUCT_V1("meta.llama3-2-1b-instruct-v1:0"),
Copy link
Member

@markpollack markpollack Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also cross-region ids, see - https://docs.aws.amazon.com/bedrock/latest/userguide/cross-region-inference-support.html not so sure how important it is to have enums or support for this approach. toughts?

Copy link
Member

@markpollack markpollack Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids.html added to the javadoc for future reference.

Copy link
Contributor Author

@dafriz dafriz Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there is an issue raised about support for cross-region inference - #1282 Let's discuss there as this issue is closed.


/**
* meta.llama3-2-3b-instruct-v1:0
*/
LLAMA3_2_3B_INSTRUCT_V1("meta.llama3-2-3b-instruct-v1:0"),

/**
* meta.llama3-2-11b-instruct-v1:0
*/
LLAMA3_2_11B_INSTRUCT_V1("meta.llama3-2-11b-instruct-v1:0"),

/**
* meta.llama3-2-90b-instruct-v1:0
*/
LLAMA3_2_90B_INSTRUCT_V1("meta.llama3-2-90b-instruct-v1:0");

private final String id;

Expand Down