Skip to content

Conversation

@JM-Lab
Copy link
Contributor

@JM-Lab JM-Lab commented Dec 4, 2023

  • Add spring-boot-starter-webflux dependency
  • Implement OpenAiEmbeddingWebClient, extending EmbeddingClient with WebClient
  • Add spring-boot-starter-webflux dependency

OpenAiEmbeddingWebClient replaces the existing OpenAiEmbeddingClient, removing the dependency on openai-java. The goal is to merge this alongside #118, ensuring that the in-house OpenAI client mentioned in #116 becomes the only remaining client, setting the stage for the eventual removal of the openai-java dependency.

@JM-Lab JM-Lab marked this pull request as ready for review December 6, 2023 12:42
@markpollack
Copy link
Member

Thank you very much for this, I hope we can get it into 0.8.0 release as well as the streaming support.

@markpollack markpollack added this to the 0.8.0 milestone Dec 6, 2023
@JM-Lab
Copy link
Contributor Author

JM-Lab commented Dec 9, 2023

Thanks! Excited about the potential inclusion in 0.8.0 release. Let me know if there's anything else.

@tzolov
Copy link
Contributor

tzolov commented Dec 13, 2023

@JM-Lab, thank you for the help.

I've refactored the spring-ai-openai to replace the theokanning client with OpenAiApi - build on spring ecosystem (e.g. WebClient and RestClient) and solving few issues that theokanning imposed.
In the process I refactored the OpenAiClient and the OpenEmbeddingClient so that both are using the native OpenAiApi.

I'm afraid that those changes could make this PR redundant. Please review an let me know. If you have time you can review my flux implementation as well (not my forte) ;)

@tzolov
Copy link
Contributor

tzolov commented Dec 17, 2023

@JM-Lab, since you did't reply i'm assuming that there is nothing more to do. So I'm closing this PR as resolved by e30be94

@tzolov tzolov closed this Dec 17, 2023
@JM-Lab
Copy link
Contributor Author

JM-Lab commented Dec 17, 2023

@tzolov Please review the contents of #172
Additionally, can you share guidelines on how to perform reviews for this project?

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants