Skip to content

Set redis query limit to match requested topK used in KNN search #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set redis query limit to match requested topK used in KNN search #1423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...ing-ai-redis-store/src/main/java/org/springframework/ai/vectorstore/RedisVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ public Optional<Boolean> doDelete(List<String> idList) {
@Override
public List<Document> doSimilaritySearch(SearchRequest request) {

Assert.isTrue(request.getTopK() > 0, "The number of documents to returned must be greater than zero");
Assert.isTrue(request.getTopK() > 0, "The number of documents to be returned must be greater than zero");
Assert.isTrue(request.getSimilarityThreshold() >= 0 && request.getSimilarityThreshold() <= 1,
"The similarity score is bounded between 0 and 1; least to most similar respectively.");

Expand All @@ -382,6 +382,7 @@ public List<Document> doSimilaritySearch(SearchRequest request) {
Query query = new Query(queryString).addParam(EMBEDDING_PARAM_NAME, RediSearchUtil.toByteArray(embedding))
.returnFields(returnFields.toArray(new String[0]))
.setSortBy(DISTANCE_FIELD_NAME, true)
.limit(0, request.getTopK())
.dialect(2);

SearchResult result = this.jedis.ftSearch(this.config.indexName, query);
Expand Down