Skip to content

Fix NPE in source metadata of TextReader #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix NPE in source metadata of TextReader #1429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions spring-ai-core/src/main/java/org/springframework/ai/reader/TextReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ public class TextReader implements DocumentReader {
private final Resource resource;

/**
* @return Character set to be used when loading data from the
* Character set to be used when loading data from the
*/
private Charset charset = StandardCharsets.UTF_8;

private Map<String, Object> customMetadata = new HashMap<>();
private final Map<String, Object> customMetadata = new HashMap<>();

public TextReader(String resourceUrl) {
this(new DefaultResourceLoader().getResource(resourceUrl));
Expand Down Expand Up @@ -85,7 +85,8 @@ public List<Document> get() {

// Inject source information as a metadata.
this.customMetadata.put(CHARSET_METADATA, this.charset.name());
this.customMetadata.put(SOURCE_METADATA, this.resource.getFilename());
this.customMetadata.put(SOURCE_METADATA, this.resource.getFilename() != null ? this.resource.getFilename()
: Objects.toIdentityString(this.resource));

return List.of(new Document(document, this.customMetadata));

Expand Down