Add conditinal support for logging errors in observation Span #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Useful for not Web apps. - Introduce ErrorLoggingObservationHandler for tracing errors across various AI contexts - Add error logging configuration option to ChatObservationProperties - Include ErrorLoggingObservationHandler bean in ChatObservationAutoConfiguration Resolves spring-projects#1440
markpollack
reviewed
Oct 4, 2024
| /** | ||
| * Whether to include error logging in the observations. | ||
| */ | ||
| private boolean includeErrorLogging = false; |
There was a problem hiding this comment.
i'll add this to observability/index.adoc
markpollack
reviewed
Oct 4, 2024
| havingValue = "true") | ||
| public ErrorLoggingObservationHandler errorLoggingObservationHandler(Tracer tracer) { | ||
| return new ErrorLoggingObservationHandler(tracer, | ||
| List.of(EmbeddingModelObservationContext.class, ImageModelObservationContext.class, |
There was a problem hiding this comment.
is it ok for the property pring.ai.chat.observations.include-error-logging to apply to all these context's as compared to the chatmodel one, e.g. embedding?
|
merged in d6dc2b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1440