Upgrade pinecone java client to 2.1.0 #1501
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Will review post 1.0 M3 as this will bring in a new version of the protobuf library and could conflict with milvus and others that use it since typically version mismatches in this library are breaking changes. |
LuizyHub
added a commit
to HansungCampusLink/HansungRag
that referenced
this pull request
Nov 7, 2024
Pinecone 2.1.0 VectorStore based on code below - code : https://github.com/spring-projects/spring-ai/blob/8703e994893f7e20f2df1fc5d204462c1e6d2769/vector-stores/spring-ai-pinecone-store/src/main/java/org/springframework/ai/vectorstore/PineconeVectorStore.java - related PR : spring-projects/spring-ai#1501
| this.namespace = builder.namespace; | ||
| this.contentFieldName = builder.contentFieldName; | ||
| this.distanceMetadataFieldName = builder.distanceMetadataFieldName; | ||
|
|
There was a problem hiding this comment.
@jiwhiz Thanks for the PR. Could you explain the reasoning for this change - removal of the some of the existing properties, client configuration and the usage of Index as part of this client version update?
|
it would be great to use 3.1.0 instead. Client can be configured to use a local emulator for testing. |
|
BTW, Testcontainers provides a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinecone Java Client released 2.1.0, and currently spring-ai still uses 0.8.0 version.