Skip to content

Conversation

@habuma
Copy link
Member

@habuma habuma commented Oct 26, 2024

This PR fixes two problems with Stability AI image generation:

  • For Stability AI-specific options, the mergeOptions() method was only copying the default options (which were null unless otherwise specified in configuration properties). Consequently, setting those options (such as style preset) in Java code achieved nothing. The main part of this PR fixes that to merge the Stability default properties with runtime properties the same as for portable options.
  • There was a typo in the JSON property name for style_preset (it was "style_present"), preventing that property from being serialized into JSON correctly.

@markpollack
Copy link
Member

Thanks. I asked Claude to write a test for the PR and low and behold, it found an bug. So neat. We maybe able to use ModelOptionsUtils here, but I didn't try.

Merged in ac4571e

@markpollack markpollack self-assigned this Oct 28, 2024
@markpollack markpollack added this to the 1.0.0-M4 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants