GH-513 fix: Support custom field names for Milvus VectorStore collection #1616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orStore collection - Add configuration properties to override the default field names for doc_id, content, metadata and embedding - Add support to allow auto-id when enabled - Add tests Resolves spring-projects#513
sobychacko
requested changes
Oct 29, 2024
| */ | ||
| @Testcontainers | ||
| @EnabledIfEnvironmentVariable(named = "OPENAI_API_KEY", matches = ".+") | ||
| public class MilvusVectorStoreCustomFieldNamesIT { |
There was a problem hiding this comment.
We can drop the public modifier and keep it at default access.
|
|
||
| @ParameterizedTest(name = "{0} : {displayName} ") | ||
| @ValueSource(strings = { "COSINE" }) | ||
| public void searchWithCustomFieldNames(String metricType) { |
|
|
||
| @ParameterizedTest(name = "{0} : {displayName} ") | ||
| @ValueSource(strings = { "COSINE" }) | ||
| public void searchWithoutMetadataFieldOverride(String metricType) { |
|
|
||
| @ParameterizedTest(name = "{0} : {displayName} ") | ||
| @ValueSource(strings = { "COSINE" }) | ||
| public void searchWithAutoIdEnabled(String metricType) { |
|
|
||
| @SpringBootConfiguration | ||
| @EnableAutoConfiguration(exclude = { DataSourceAutoConfiguration.class }) | ||
| public static class TestApplication { |
| private String metadataFieldName; | ||
|
|
||
| @Bean | ||
| public VectorStore vectorStore(MilvusServiceClient milvusClient, EmbeddingModel embeddingModel) { |
| } | ||
|
|
||
| @Bean | ||
| public MilvusServiceClient milvusClient() { |
| } | ||
|
|
||
| @Bean | ||
| public EmbeddingModel embeddingModel() { |
| } | ||
|
|
||
| @Test | ||
| public void searchWithCustomFields() { |
There was a problem hiding this comment.
Author tag needs to be updated for this class.
leijendary
pushed a commit
to leijendary/spring-ai
that referenced
this pull request
Jan 24, 2025
…orStore collection (spring-projects#1616) * spring-projectsGH-513 fix: Support custom field names for Milvus VectorStore collection - Add configuration properties to override the default field names for doc_id, content, metadata and embedding - Add support to allow auto-id when enabled - Add tests Resolves spring-projects#513 * Fix package modifier Signed-off-by: leijendary <[email protected]>
leijendary
pushed a commit
to leijendary/spring-ai
that referenced
this pull request
Jan 24, 2025
…orStore collection (spring-projects#1616) * spring-projectsGH-513 fix: Support custom field names for Milvus VectorStore collection - Add configuration properties to override the default field names for doc_id, content, metadata and embedding - Add support to allow auto-id when enabled - Add tests Resolves spring-projects#513 * Fix package modifier Signed-off-by: leijendary <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #513