Skip to content

Conversation

@jitokim
Copy link
Contributor

@jitokim jitokim commented Oct 29, 2024

chatclient.adoc

  • Replaced javaCopySimpleLoggerAdvisor with SimpleLoggerAdvisor
  • Fixed typo in the multiline String for ChatClient example

etl-pipeline.adoc

  • Fixed indent in the ParagraphPdfDocumentReader example

imageclient.adoc

  • Fixed indent of override annotation in the ImageGeneration example

testing.adoc

  • Added a semicolon to the Evaluator interface

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

chatclient.adoc
 - Replaced javaCopySimpleLoggerAdvisor with SimpleLoggerAdvisor
 - Fixed typo in the multiline String for ChatClient example

etl-pipeline.adoc
 - Fixed indent in the ParagraphPdfDocumentReader example

imageclient.adoc
 - Fixed indent of override annotation in the ImageGeneration example

testing.adoc
 - Added a semicolon to the Evaluator interface

Signed-off-by: jitokim <[email protected]>
@markpollack markpollack added the documentation Improvements or additions to documentation label Oct 29, 2024
@sobychacko sobychacko added this to the 1.0.0-M4 milestone Oct 30, 2024
@sobychacko sobychacko self-assigned this Oct 30, 2024
@sobychacko sobychacko merged commit cf17a6d into spring-projects:main Oct 30, 2024
1 check passed
leijendary pushed a commit to leijendary/spring-ai that referenced this pull request Jan 24, 2025
chatclient.adoc
 - Replaced javaCopySimpleLoggerAdvisor with SimpleLoggerAdvisor
 - Fixed typo in the multiline String for ChatClient example

etl-pipeline.adoc
 - Fixed indent in the ParagraphPdfDocumentReader example

imageclient.adoc
 - Fixed indent of override annotation in the ImageGeneration example

testing.adoc
 - Added a semicolon to the Evaluator interface

Signed-off-by: jitokim <[email protected]>
Signed-off-by: leijendary <[email protected]>
leijendary pushed a commit to leijendary/spring-ai that referenced this pull request Jan 24, 2025
chatclient.adoc
 - Replaced javaCopySimpleLoggerAdvisor with SimpleLoggerAdvisor
 - Fixed typo in the multiline String for ChatClient example

etl-pipeline.adoc
 - Fixed indent in the ParagraphPdfDocumentReader example

imageclient.adoc
 - Fixed indent of override annotation in the ImageGeneration example

testing.adoc
 - Added a semicolon to the Evaluator interface

Signed-off-by: jitokim <[email protected]>
Signed-off-by: leijendary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants