Feature (ZhiPuAi): Support for Embedding-3 Model #1640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests - Add Embedding_3 Model in ZhiPuAiApi - Add embedding3 Test Cases in EmbeddingIT
| assertThat(embeddingResponse.getResults().get(0)).isNotNull(); | ||
| assertThat(embeddingResponse.getResults().get(0).getOutput()).hasSize(2048); | ||
|
|
||
| // assertThat(this.embeddingModel.dimensions()).isEqualTo(2048); |
There was a problem hiding this comment.
The changes look good! It is weird that the embedding model dimensions is "-1". Do you know why?
There was a problem hiding this comment.
@wb04307201 The ZhipuAiApi Embedding model is updated with Embedding-2 and Embedding-3. Since we haven't heard back on the test, I couldn't merge the PR earlier. Closing this PR for now. Please create a new PR with the updated test if you prefer. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is Support for Embedding-3 Model and Update Related Tests.
the PR content: