Fix: convert API records to POJOs and fix related tests #1649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following removal of Spring Boot's ConstructorBinding, convert record types to regular POJOs to maintain JSON serialization. Update API classes: - Convert FunctionTool and Function records to standard Java classes with getters/setters - Update test assertions to use getter methods instead of record accessors - Fix failing tests in MiniMax, OpenAi and ZhiPu API implementations This keeps core API models independent of Spring Boot while ensuring proper serialization through standard Java beans.
Member
|
There are failing tests related to the changes. I suspect that the OPEN_AI_KEY may not have been set or the tests in |
Member
|
I'm disabling the failing tests in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following removal of Spring Boot's ConstructorBinding, convert record types to regular POJOs to maintain JSON serialization. Update API classes:
This keeps core API models independent of Spring Boot while ensuring proper serialization through standard Java beans.