Fix duplicate keys in ChatResponseMetadata for OllamaApi.ChatResponse #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metadata Fix assertion in contructor of OllamaChatModel Signed-off-by: jitokim <[email protected]>
jitokim
force-pushed
the
fix-metadata-key-duplication
branch
from
5869bee to
7a72a72
Compare
Signed-off-by: jitokim <[email protected]>
|
@ilayaperumalg |
|
@jitokim Thanks for the PR! The changes look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval-durationandeval-countwere duplicated.so they have been updated to
prompt-eval-durationandprompt-eval-countto avoid overwrite.AS-IS
TO-BE
ModelManagementOptions.AS-IS
Incorrect object was being asserted.
observationRegistrySo, NPE occurs at line 105 where OllamaModelManager is being created.
TO-BE
Replace observationRegistry with
ModelManagementOptionsProper exception handling and error messages for modelManagementOptions.