GH-1679 Disable BedrockConverseProxyChatAutoConfiguration by default #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion by default - Set the default value for spring.ai.bedrock.anthropic.chat.enabled to false to disable the BedrockConverseProxyChatAutoConfiguration by default - This will make sure that the BedrockConverseProxy auto configuration wouldn't conflict with other related Bedrock autoconfigs (ex: BedrockAnthropic3ChatAutoConfiguration) - Update documentation for the default behaviour - Update tests Resolves spring-projects#1679
|
We should not disable the BedrockConverseProxyChatAutoConfiguration by default!!! The solution for #1679 is to add |
|
@tzolov Thanks for the explanation. I will go ahead and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default value for spring.ai.bedrock.anthropic.chat.enabled to false to disable the BedrockConverseProxyChatAutoConfiguration by default
This will make sure that the BedrockConverseProxy auto configuration wouldn't conflict with other related Bedrock autoconfigs (ex: BedrockAnthropic3ChatAutoConfiguration)
Update documentation for the default behaviour
Update tests
Resolves #1679