GH-1240: Add builder pattern to ChromaVectorStore for better initiali… #1723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…better initialization control Fixes: spring-projects#1240 Issue: spring-projects#1240 The change addresses initialization issues when ChromaVectorStore is used outside Spring context, particularly in scenarios where collections are created manually before store instantiation. Previously, collection ID wasn't properly populated when afterPropertiesSet() wasn't called by Spring container. - Add builder pattern to ChromaVectorStore for better initialization control - Add initialization flag to prevent multiple collection creation calls - Add integration tests for builder pattern usage scenarios - Add spring-ai-transformers dependency for testing - Remove unused constants (SIMILARITY_THRESHOLD_ALL, DEFAULT_TOP_K) Collection ID is now properly set regardless of whether the store is managed by Spring or created manually, solving the 404 Not Found errors during document insertion.
markpollack
reviewed
Nov 12, 2024
| this.objectMapper = JsonMapper.builder().addModules(JacksonUtils.instantiateAvailableModules()).build(); | ||
| } | ||
|
|
||
| private ChromaVectorStore(Builder builder) { |
There was a problem hiding this comment.
I think this is yet another variation of the builder pattern in our docs, any reason not to have this code inside the builder's build method?
|
merged in c8a9b16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…zation control
Fixes: #1240
Issue: #1240
The change addresses initialization issues when ChromaVectorStore is used outside Spring context, particularly in scenarios where collections are created manually before store instantiation. Previously, collection ID wasn't properly populated when afterPropertiesSet() wasn't called by Spring container.
Collection ID is now properly set regardless of whether the store is managed by Spring or created manually, solving the 404 Not Found errors during document insertion.