Skip to content

Conversation

@ilayaperumalg
Copy link
Member

  • Fix the embedding dimension configuration for opensearch client indices mapping
    • The dimension config is obtained by the underlying embedding model's dimension

Resolves #1589

 - Fix the embedding dimension configuration for opensearch client indices mapping
    - The dimension config is obtained by the underlying embedding model's dimension

Resolves spring-projects#1589
@ilayaperumalg ilayaperumalg requested a review from tzolov November 12, 2024 12:51
@markpollack
Copy link
Member

Add docs. Also test case when the properties string is provided by the user but there isn't a %s in the string, does it fail?

 - Verify the mappingJson field is correctly set
   - verify the override works fine
 - Add integration tests with Ollama embedding model
@markpollack markpollack self-assigned this Nov 14, 2024
@markpollack markpollack added this to the 1.0.0-M4 milestone Nov 14, 2024
@tzolov
Copy link
Contributor

tzolov commented Nov 19, 2024

rebased, squashed and merged at de53e64

@tzolov tzolov closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opensearch vector store bugs

3 participants