GH-1529 Fix ChromaVectorStore delete Ids operation #1730
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As a result of the the change:chroma-core/chroma#2880 introduced in chroma:0.5.13,the delete operation doesn't return any values. Hence, we need to check the Http Client Response with the status code instead of return value. - Check the status code for successful delete operation - Update test Resolves spring-projects#1529
markpollack
reviewed
Nov 13, 2024
| public String deleteEmbeddings(String collectionId, DeleteEmbeddingsRequest deleteRequest) { | ||
|
|
||
| return this.restClient.post() | ||
| return String.valueOf(this.restClient.post() |
There was a problem hiding this comment.
why return a string instead of the http status code which is an int?
|
changed to return int and merged as a98c042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1529