Add LocalStack OpenSearch Service Connection support for Docker Compose and Testcontainers #1735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se and Testcontainers * Add property `spring.ai.vectorstore.opensearch.aws.domain-name` * Require `AwsCredentialsProvider` to enable `AwsOpenSearchConfiguration` * Add Testcontainers Service Connection support * Add Docker Compose Service Connection support
eddumelendez
changed the title
| org.testcontainers.containers.Container.ExecResult execResult = localstack | ||
| .execInContainer(describeDomainCmd); | ||
| String response = execResult.getStdout(); | ||
| JSONArray processed = JsonPath.read(response, "$.DomainStatus[?(@.Processing == false)]"); |
There was a problem hiding this comment.
@eddumelendez Thanks for the PR. This test consistently times out here. I believe this is probably an environment issue but want to check with you.
There was a problem hiding this comment.
@eddumelendez suggested to increase the timeout value as the localstack tries to pull the open search binaries could take longer depending on the internet bandwidth. It worked after increasing to a longer timeout on my local. Thanks!
|
@eddumelendez Thanks for the PR! The changes look good to me. Ran the tests locally to validate, rebased and merged as 6261ce0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spring.ai.vectorstore.opensearch.aws.domain-nameAwsCredentialsProviderto enableAwsOpenSearchConfiguration