Skip to content

Conversation

jruaux
Copy link
Contributor

@jruaux jruaux commented Dec 18, 2023

This PR adds supports for Redis vector search.

@tzolov
Copy link
Contributor

tzolov commented Dec 18, 2023

Hi @jruaux , thank you for the contribution.
I will have a deeper look shortly, but wanted to let you know that I appreciate the extra effort in implementing the filters as well ;)

@jruaux
Copy link
Contributor Author

jruaux commented Dec 18, 2023

@tzolov Happy to contribute to the project. Please let me know if anything needs work

@markpollack
Copy link
Member

Hi @jruaux. Thanks so much. I just squashed and added some Javadoc. Great job.

Closed in a232166

@tzolov
Copy link
Contributor

tzolov commented Dec 22, 2023

Hi @jruaux ,
just noticed the Redis auto-configuration (like https://github.com/spring-projects/spring-ai/tree/main/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure) is missing.
Without an auto-configuraiton the spring-ai-starter-redis boot starter is usless.

Please let me know if you have time and interest to contribute the missing auto-configuration. You can consult the other vectors' auto configuration impls for example or we can arrange a peer session ;)
Otherwise we should remove the redis starter for until the auto-conf is implemented.

@jruaux
Copy link
Contributor Author

jruaux commented Dec 22, 2023

Hi @tzolov, there is a RedisVectorStoreAutoConfiguration under https://github.com/spring-projects/spring-ai/tree/main/spring-ai-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/redis

Is that what you were looking for?

@tzolov
Copy link
Contributor

tzolov commented Dec 23, 2023

Sorry @jruaux, i overlooked it.Indeed everything is OK. Thank you again

@markpollack markpollack added this to the 0.8.0 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants