Skip to content

Conversation

Sohardh
Copy link

@Sohardh Sohardh commented Dec 18, 2023

Fix #114

@Sohardh Sohardh changed the title Adds Spring boot starter for Ne04j Store Adds Spring boot starter for Neo4j Store Dec 18, 2023
@markpollack
Copy link
Member

Thanks! 🙇‍♂️ Merged as 5b46361

@tzolov
Copy link
Contributor

tzolov commented Dec 18, 2023

@markpollack @Sohardh there is not Auto-configuration for the Neo4j. Without an auto-config there can't be spring boot starter either.
So what exactly is this PR about and why is it merged?

@King-Chau
Copy link
Contributor

@markpollack @Sohardh there is not Auto-configuration for the Neo4j. Without an auto-config there can't be spring boot starter either. So what exactly is this PR about and why is it merged?

I have the same question. Why there is not Neo4jAutoConfiguration? Does this starer work?

@tzolov
Copy link
Contributor

tzolov commented Dec 22, 2023

@King-Chau No this was a mistake and I've removed the starter, Btw same mistake applies for the Redis vector store.

If interested, please fill free to contribute auto-configuration and a starter: #114

@King-Chau
Copy link
Contributor

@King-Chau No this was a mistake and I've removed the starter, Btw same mistake applies for the Redis vector store.

If interested, please fill free to contribute auto-configuration and a starter: #114

@tzolov I will add neo4j auto-configuration

@tzolov
Copy link
Contributor

tzolov commented Dec 24, 2023

Thanks to @King-Chau we have a neo4j-autoconifugraiton.
I will see if i can (re)introduce this PR and adjust its pom to include the above autoconfig.

@tzolov tzolov reopened this Dec 24, 2023
@tzolov
Copy link
Contributor

tzolov commented Dec 24, 2023

squashed, rebased and merged at: 5ba78c2

@tzolov tzolov closed this Dec 24, 2023
@markpollack markpollack added this to the 0.8.0 milestone Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Auto-Configurations and Boot starters for all Vector Store implementations
4 participants