add ollama model options:llama-vision,qwen2.5 #1774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogbozoyan
reviewed
Nov 23, 2024
| @Override | ||
| public String getName() { | ||
| return this.id; | ||
| return this.id + (null == this.size ? "" : ":" + this.size); |
There was a problem hiding this comment.
Missing Null Handling in getName:
The logic in getName assumes size will be null or non-empty but doesn't guard against unexpected input like an empty string.
Add validation to handle this edge case
Contributor
Author
There was a problem hiding this comment.
If there is no difference between id and name, then that's right
| @Override | ||
| public String getName() { | ||
| return this.id; | ||
| return this.id + (null == this.size ? "" : ":" + this.size); |
There was a problem hiding this comment.
Suggested change
| return this.id + (null == this.size ? "" : ":" + this.size); | |
| return this.id + (this.size == null || this.size.isEmpty() ? "" : ":" + this.size); |
…llama/api/OllamaModel.java If there is no difference between id and name, then that's right Co-authored-by: ogbozoyan <[email protected]>
ogbozoyan
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add ollama model options:llama-vision,qwen2.5