refactor: enhance ChatGenerationMetadata with metadata Map and Builder #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ChatGenerationMetadata provides Map for additional metadata - Add Builder interface and DefaultChatGenerationMetadataBuilder - Add DefaultChatGenerationMetadata implementation - Update all AI model implementations to use the new builder pattern - Deprecate ChatGenerationMetadata.from() factory method Resolves spring-projects#1805
| chunk.amazonBedrockInvocationMetrics()); | ||
| chatGenerationMetadata = ChatGenerationMetadata.builder() | ||
| .finishReason(completionReason) | ||
| .metadata("usage", chunk.amazonBedrockInvocationMetrics()) |
Member
There was a problem hiding this comment.
The class BedrockUsage has AmazonBedrockInvocationMetrics getUsage() so maybe it is the other way around, the class name should change? Prob not that important as we will remove this on the switch to bedrock converse.
| response.usage().outputTokens())); | ||
| chatGenerationMetadata = ChatGenerationMetadata.builder() | ||
| .finishReason(response.delta().stopReason()) | ||
| .metadata("usage", |
Member
There was a problem hiding this comment.
Can we move all these common metadata keys to constants?
| } | ||
| }; | ||
| } | ||
| // /** |
Member
There was a problem hiding this comment.
commented out code can be deleted.
Member
|
removed commented out code and made other small changes. merged in f388f53 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1805