fix : Fix Image Path and Broken xref Links in Documentation #1813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowboysj
changed the title
tzolov
reviewed
Nov 30, 2024
| //// **** xref:api/chat/functions/moonshot-chat-functions.adoc[Function Calling] | ||
| *** xref:api/chat/nvidia-chat.adoc[NVIDIA] | ||
| *** xref:api/chat/ollama-chat.adoc[Ollama] | ||
| * xref:pages/index.adoc[Overview] |
There was a problem hiding this comment.
I don't think pages prefix is needed? why do you think it does?
| = Introduction | ||
|
|
||
| image::spring_ai_logo_with_text.svg[Integration Problem, width=300, align="left"] | ||
| image::../images/spring_ai_logo_with_text.svg[Integration Problem, width=300, align="left"] |
There was a problem hiding this comment.
I was wondering... isn't the problem the underscore on the file name? I've seen all of other functional logos in the spring doc website and all the use hyphen. Besides the diagram is functional.
markpollack
reviewed
May 6, 2025
| ** xref:api/vectordbs/hana.adoc[SAP Hana] | ||
| ** xref:api/vectordbs/typesense.adoc[] | ||
| ** xref:api/vectordbs/weaviate.adoc[] | ||
| * xref:pages/api/vectordbs.adoc[] |
There was a problem hiding this comment.
I don't understand these changes. the antora bild works fine.
|
I think there is something wrong in your build envioronment @cowboysj The docs build is working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1812
Image Path Corrections
Fixed multiple incorrect image paths causing rendering errors in the documentation.
Updated image references to use consistent and correct relative paths, ensuring compatibility with the Antora structure.
Broken xref Link Updates
Resolved several broken or outdated xref links in the documentation.
Updated the links to match the correct file structure and ensured navigation works seamlessly.
Changes Made
Image Path Updates
image::spring-ai-prompt-stuffing.jpg[Prompt stuffing, width=700, align="center"]image::../images/spring-ai-prompt-stuffing.jpg[Prompt stuffing, width=700, align="center"]xref Link Updates
xref:api/chat/bedrock/bedrock-anthropic3.adoc[Anthropic3]xref:pages/api/chat/bedrock/bedrock-anthropic3.adoc[Anthropic3]