refactor(vectorstore): introduce builder pattern for MilvusVectorStore #1885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .withMetadataFieldName(properties.getMetadataFieldName()) | ||
| .withEmbeddingFieldName(properties.getEmbeddingFieldName()) | ||
| return MilvusVectorStore.builder(milvusClient) | ||
| .embeddingModel(embeddingModel) |
There was a problem hiding this comment.
Except isInitializeSchema, rest of the configuration properties don't seem to be set via builder.
There was a problem hiding this comment.
We also need a test to validate this case in our AutoConfiguration IT for Milvus.
There was a problem hiding this comment.
@ilayaperumalg Created this issue to track this: #1903. Maybe we can tackle this as a separate issue outside the scope of the builder refactoring?
- Replace configuration object with fluent builder pattern - Move Milvus-related classes to dedicated milvus package - Deprecate MilvusVectorStoreConfig in favor of builder - Update constructor to use builder internally - Maintain backward compatibility with deprecated config - Add comprehensive builder methods with validation
sobychacko
force-pushed
the
milvus-vector-store-builder
branch
from
2b0b504 to
b22cbb8
Compare
|
merged in 218c967 |
1 similar comment
|
merged in 218c967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.