Refactor Azure OpenAi #192
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzolov
commented
Dec 22, 2023
tzolov
commented
- Clean the AzureOpenAiChatClient and add support for StreamingChatClient.
- Streamline the AzureOpenAiEmbeddingClient.
- Move the AzureOpenAiChatClient and AzureOpenAiEmbeddingClient to top org.sf.ai.azure.opoenai package.
- Add ITs for AzureOpenAiChatClient and AzureOpenAiEmbeddingClient
- Fix the AzureOpenAiAutoConfiguration
- Split property file into AzureOpienAiConnectionProperties, AzureOpenAiChatProperties and AzureOpenAiEmbeddingProperties.
- Add ITs for the auto-configuration
- Add improve package structure
- Add README docs
JM-Lab
reviewed
Dec 23, 2023
| .map(ChatCompletions::getChoices) | ||
| .flatMap(List::stream) | ||
| .map(choice -> { | ||
| System.out.println(choice.getDelta()); |
There was a problem hiding this comment.
Leaving the System.out.println as just an accidental leftover?
tzolov
force-pushed
the
azure-openai-improvments
branch
from
08268be to
ad6b3cf
Compare
- Clean the AzureOpenAiChatClient and add support for StreamingChatClient.
- Streamline the AzureOpenAiEmbeddingClient.
- Move the AzureOpenAiChatClient and AzureOpenAiEmbeddingClient to top org.sf.ai.azure.opoenai package.
- Add ITs for AzureOpenAiChatClient and AzureOpenAiEmbeddingClient
- Fix the AzureOpenAiAutoConfiguration
- Split property file into AzureOpienAiConnectionProperties, AzureOpenAiChatProperties
and AzureOpenAiEmbeddingProperties.
- Add ITs for the auto-configuration
- Add improve package structure
- Add README docs
tzolov
force-pushed
the
azure-openai-improvments
branch
from
ad6b3cf to
0663c73
Compare
|
merged in 0ccf327 Updated github actions secrets to run Azure IT tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.