Skip to content

Conversation

@bartveenstra
Copy link

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@bartveenstra bartveenstra changed the title Added JSON Schema Response Format for Azure OpenAI for Strucutred Report Added JSON Schema Response Format for Azure OpenAI for Structured Output Dec 19, 2024
@markpollack markpollack added this to the 1.0.0-M5 milestone Dec 20, 2024
@tzolov tzolov modified the milestones: 1.0.0-M5, 1.0.0-M6 Dec 20, 2024
@ilayaperumalg ilayaperumalg self-assigned this Feb 12, 2025
@ilayaperumalg
Copy link
Member

@bartveenstra Could you please sign off to validate the DCO check? Thanks

To do this, you can run "git commit --amend --signoff" on the commit and force push to the PR.

@ilayaperumalg ilayaperumalg modified the milestones: 1.0.0-M6, 1.0.0-M7 Feb 12, 2025
@ewan-lettingsowl
Copy link

Hi @bartveenstra would you be able to run the "git commit --amend --signoff" command mentioned by @ilayaperumalg in the previous comment. I see this PR has been raised for a while and it appears this is the main holdup to getting it merged.

Me and my team would be very grateful if you'd be able to do this as this change would be very helpful to us. Thanks!

@bartveenstra
Copy link
Author

Hi @bartveenstra would you be able to run the "git commit --amend --signoff" command mentioned by @ilayaperumalg in the previous comment. I see this PR has been raised for a while and it appears this is the main holdup to getting it merged.

Me and my team would be very grateful if you'd be able to do this as this change would be very helpful to us. Thanks!

Hi @ewan-lettingsowl . Believe me, I am trying, but my IntelliJ keeps modifying the commits. I'll try if I can resolve this today.

@rwankar
Copy link

rwankar commented Mar 2, 2025

I'm too am looking forward to this commit.

@bartveenstra
Copy link
Author

I fixed the last commit and force pushed it. Still not going through the DCO. Not sure what to do now

@bartveenstra
Copy link
Author

Sorry. I completely messed up my codebase. Checking if I can recover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants