Skip to content

Conversation

adambchouti
Copy link
Contributor

@adambchouti adambchouti commented Dec 29, 2023

When using pinecone, it would be nice to not have to create a new vectorStore instance for different namespaces. This PR is to simply:

  • add a setter to update the pinecone namespace used during requests
  • Add additional functions that allow passing a custom namespace during add, search and delete

@adambchouti
Copy link
Contributor Author

Probably best to just pass the namespace as a parameter when adding, searching and removing from the vector store

@markpollack
Copy link
Member

Thanks for this. I've created this issue #209 to better understand the APIs of vector store providers. Ideally I would like a mechanism to pass vector store provider options to each implementation in a generic way so that casting to a subtype of VectorStore is not required. See the issue for more context.

@adambchouti
Copy link
Contributor Author

Makes perfect sense, gonna close this one. Thx a lot!

@tzolov
Copy link
Contributor

tzolov commented Feb 14, 2024

merged at 36278af

@tzolov tzolov closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants