Skip to content

Make vector store builders extensible #2058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Make vector store builders extensible #2058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spring-ai-core/src/main/java/org/springframework/ai/vectorstore/SimpleVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectWriter;
import com.fasterxml.jackson.databind.json.JsonMapper;
import io.micrometer.observation.ObservationRegistry;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand All @@ -49,7 +48,6 @@
import org.springframework.ai.util.JacksonUtils;
import org.springframework.ai.vectorstore.observation.AbstractObservationVectorStore;
import org.springframework.ai.vectorstore.observation.VectorStoreObservationContext;
import org.springframework.ai.vectorstore.observation.VectorStoreObservationConvention;
import org.springframework.core.io.Resource;

/**
Expand Down
6 changes: 6 additions & 0 deletions src/checkstyle/checkstyle-suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,14 @@

<suppress files="AzureVectorStore.java" checks="FinalClass"/>
<suppress files="CassandraVectorStore.java" checks="FinalClass"/>
<suppress files="CoherenceVectorStore.java" checks="FinalClass"/>
<suppress files="CosmosDBVectorStore.java" checks="FinalClass"/>
<suppress files="GemFireVectorStore.java" checks="FinalClass"/>
<suppress files="MilvusVectorStore.java" checks="FinalClass"/>
<suppress files="HanaCloudVectorStore.java" checks="FinalClass"/>
<suppress files="MongoDBAtlasVectorStore.java" checks="FinalClass"/>
<suppress files="Neo4jVectorStore.java" checks="FinalClass"/>
<suppress files="OpenSearchVectorStore.java" checks="FinalClass"/>
<suppress files="PineconeVectorStore.java" checks="FinalClass"/>
<suppress files="TypesenseVectorStore.java" checks="FinalClass"/>
<suppress files="WeaviateVectorStore.java" checks="FinalClass"/>
Expand Down
2 changes: 1 addition & 1 deletion ...-store/src/main/java/org/springframework/ai/vectorstore/cosmosdb/CosmosDBVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ public VectorStoreObservationContext.Builder createObservationContextBuilder(Str
*
* @since 1.0.0
*/
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private final CosmosAsyncClient cosmosClient;

Expand Down
2 changes: 1 addition & 1 deletion ...tore/src/main/java/org/springframework/ai/vectorstore/coherence/CoherenceVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ public VectorStoreObservationContext.Builder createObservationContextBuilder(Str
*
* @since 1.0.0
*/
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private final Session session;

Expand Down
2 changes: 1 addition & 1 deletion ...re-store/src/main/java/org/springframework/ai/vectorstore/gemfire/GemFireVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ public void setDeleteData(boolean deleteData) {
*
* @since 1.0.0
*/
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private String host = GemFireVectorStore.DEFAULT_HOST;

Expand Down
2 changes: 1 addition & 1 deletion ...c/main/java/org/springframework/ai/vectorstore/mongodb/atlas/MongoDBAtlasVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ public static Builder builder(MongoTemplate mongoTemplate, EmbeddingModel embedd
return new Builder(mongoTemplate, embeddingModel);
}

public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private final MongoTemplate mongoTemplate;

Expand Down
2 changes: 1 addition & 1 deletion ...-neo4j-store/src/main/java/org/springframework/ai/vectorstore/neo4j/Neo4jVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ public static Builder builder(Driver driver, EmbeddingModel embeddingModel) {
return new Builder(driver, embeddingModel);
}

public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private final Driver driver;

Expand Down
2 changes: 1 addition & 1 deletion ...re/src/main/java/org/springframework/ai/vectorstore/opensearch/OpenSearchVectorStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ public record OpenSearchDocument(String id, String content, Map<String, Object>
/**
* Builder class for creating OpenSearchVectorStore instances.
*/
public static final class Builder extends AbstractVectorStoreBuilder<Builder> {
public static class Builder extends AbstractVectorStoreBuilder<Builder> {

private final OpenSearchClient openSearchClient;

Expand Down
Loading