small code improvements/clean-ups #2077
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng' from SimpleVectorStoreContent class Signed-off-by: pavel <[email protected]>
| * @return a new instance with the updated embedding | ||
| * @throws IllegalArgumentException if embedding is null or empty | ||
| */ | ||
| public SimpleVectorStoreContent withEmbedding(float[] embedding) { |
There was a problem hiding this comment.
Public methods need to be deprecated first before getting deleted. I will re-add and deprecate this method instead.
|
Squashed, rebased and merged as 608b29c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small code improvements/clean-ups, deleted unused method 'withEmbedding' from SimpleVectorStoreContent class