Skip to content

Resolve MistralAiApiToolFunctionCallIT issue and activate testing. #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Resolve MistralAiApiToolFunctionCallIT issue and activate testing. #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...c/test/java/org/springframework/ai/mistralai/api/tool/MistralAiApiToolFunctionCallIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
import org.slf4j.Logger;
Expand All @@ -37,14 +36,15 @@
import org.springframework.ai.mistralai.api.MistralAiApi.FunctionTool.Type;
import org.springframework.ai.model.ModelOptionsUtils;
import org.springframework.http.ResponseEntity;
import org.springframework.util.ObjectUtils;

import static org.assertj.core.api.Assertions.assertThat;

/**
* @author Christian Tzolov
* @author Ricken Bazolo
*/
@EnabledIfEnvironmentVariable(named = "MISTRAL_AI_API_KEY", matches = ".+")
@Disabled
public class MistralAiApiToolFunctionCallIT {

static final String MISTRAL_AI_CHAT_MODEL = MistralAiApi.ChatModel.LARGE.getValue();
Expand Down Expand Up @@ -121,7 +121,7 @@ public void toolFunctionCall() throws JsonProcessingException {
assertThat(responseMessage.toolCalls()).isNotNull();

// Check if the model wanted to call a function
if (responseMessage.toolCalls() != null) {
if (!ObjectUtils.isEmpty(responseMessage.toolCalls())) {

// extend conversation with assistant's reply.
messages.add(responseMessage);
Expand All @@ -137,7 +137,7 @@ public void toolFunctionCall() throws JsonProcessingException {

// extend conversation with function response.
messages.add(new ChatCompletionMessage("" + weatherResponse.temp() + weatherRequest.unit(),
Role.TOOL, functionName, null));
Role.TOOL, functionName, null, toolCall.id()));
}
}

Expand Down
Loading