Add filter-based deletion and refactor tests for Pinecone vector store #2142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add string-based filter deletion alongside the Filter.Expression-based deletion for Pinecone vector store and improve test organization through refactoring. Key changes: - Add delete(Filter.Expression) implementation using two-step process: * Search for documents matching filter * Delete matching documents by ID - Leverage existing search functionality to maintain filter consistency - Extract common test patterns into helper methods - Create reusable document factory methods for test data - Add comprehensive integration tests for filter deletion - Standardize test cleanup and verification patterns This maintains consistency with other vector store implementations while working within Pinecone's API limitations. The test refactoring improves maintainability and makes the test patterns clearer and more consistent. Signed-off-by: Soby Chacko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string-based filter deletion alongside the Filter.Expression-based deletion for Pinecone vector store and improve test organization through refactoring.
Key changes:
This maintains consistency with other vector store implementations while working within Pinecone's API limitations. The test refactoring improves maintainability and makes the test patterns clearer and more consistent.