Add filter-based deletion to Weaviate vector store #2150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement filter-based deletion for WeaviateVectorStore by leveraging the existing ID-based deletion mechanism. Key changes: - Add doDelete(Filter.Expression) implementation that delegates to the existing ID-based deletion method - Use similarity search with filter to find matching documents first - Delete matched documents by their IDs - Add integration tests for filter deletion scenarios: * Deleting by simple equality filter * Deleting by string-based filter expression This maintains consistency with other vector store implementations while working around Weaviate's limitations in direct filtered deletion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement filter-based deletion for WeaviateVectorStore by leveraging the existing ID-based deletion mechanism.
Key changes:
This maintains consistency with other vector store implementations while working around Weaviate's limitations in direct filtered deletion.