Add flexible API key management for OpenAI #2164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new API key management system that allows users to customize how API keys are provided and managed in their Spring AI applications. This change improves security and flexibility by: - Adding core ApiKey interface and SimpleApiKey implementation - Introducing @OPENAIAPIKEY qualifier for bean disambiguation - Supporting custom API key providers for secure key management - Adding auto-configuration support for API key injection - Adding builder pattern for OpenAiApi configuration - Deprecating public constructors in favor of builder API (since 1.0.0.M6) The new system enables users to implement their own key management strategies while maintaining backward compatibility with property-based configuration.
markpollack
commented
Feb 4, 2025
| @Retention(RetentionPolicy.RUNTIME) | ||
| @Documented | ||
| @Qualifier | ||
| public @interface OpenAiApiKey { |
There was a problem hiding this comment.
change to OpenAiChatApiKey so it is specific to chat models, there will be OpenAiEmbeddingApiKey different models can have different endpoints.
|
Don’t merge, need to remove the annotation to override the ApiKey implementation, the strategy isn’t working out. |
|
merged in fc2690c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new API key management system that allows users to customize how API keys are provided and managed in their Spring AI applications. This change improves security and flexibility by:
The new system enables users to implement their own key management strategies while maintaining backward compatibility with property-based configuration.