Skip to content

Conversation

@BraeschAntoine
Copy link
Contributor

Missing the possibility to use image in mulitmodality for Mistral AI

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@ilayaperumalg
Copy link
Member

@BraeschAntoine , Your commit description points to Mistral AI but the change is done for Minimax model. Could you check?
Also, Could you sign the commit and re-push?

git config --global user.name "Your Name"
git config --global user.email "[email protected]"

go to PR branch

git commit --amend --signoff
git push --force

@BraeschAntoine BraeschAntoine force-pushed the patch-1 branch 5 times, most recently from 3c43e42 to fe3e5a1 Compare February 7, 2025 09:40
@ilayaperumalg
Copy link
Member

@BraeschAntoine Please check the DCO as well.

@BraeschAntoine
Copy link
Contributor Author

BraeschAntoine commented Feb 7, 2025

Yes sorry, it's kinda my first time contributing to open source, and i'm struggling a bit to have my commit signed off because i thought i had to use an GPG key and the i realized i could just add the line manually

Missing the possibility to use image in mulitmodality for Mistral AI

Signed-off-by: BraeschAntoine <[email protected]>
@ilayaperumalg
Copy link
Member

@BraeschAntoine No problem, thank you for your contribution and looking forward to see many more contributions ahead!

@ilayaperumalg ilayaperumalg added this to the 1.0.0-M6 milestone Feb 7, 2025
@ilayaperumalg ilayaperumalg merged commit 171b758 into spring-projects:main Feb 7, 2025
2 checks passed
@ilayaperumalg ilayaperumalg self-assigned this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants