Use ApiKey for OpenAI Image/Audio/Moderation APIs #2226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ilayaperumalg
commented
Feb 12, 2025
ilayaperumalg
commented
- Update to use ApiKey when instantiating OpenAI Image/Audio/Moderation APIs
- Add Builders for OpenAI Image/Audio/Moderation APIs and deprecate existing constructors
tzolov
reviewed
Feb 13, 2025
|
|
||
| public Builder apiKey(String simpleApiKey) { | ||
| Assert.notNull(simpleApiKey, "apiKey cannot be null"); | ||
| Assert.hasText(simpleApiKey, "simpleApiKey cannot be empty or null"); |
There was a problem hiding this comment.
Non null is fine but why empty should not be excluded, IMO
| } | ||
|
|
||
| public Builder apiKey(String simpleApiKey) { | ||
| Assert.hasText(simpleApiKey, "simpleApiKey cannot be empty or null"); |
There was a problem hiding this comment.
Same , empty text should be allowed?
| } | ||
|
|
||
| public Builder apiKey(String simpleApiKey) { | ||
| Assert.hasText(simpleApiKey, "simpleApiKey cannot be empty or null"); |
There was a problem hiding this comment.
Same , empty text should be allowed?
| } | ||
|
|
||
| public Builder apiKey(String simpleApiKey) { | ||
| Assert.hasText(simpleApiKey, "simpleApiKey cannot be empty or null"); |
- Update to use ApiKey when instantiating OpenAI Image/Audio/Moderation APIs - Add Builders for OpenAI Image/Audio/Moderation APIs and deprecate existing constructors - Add/update tests Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
- Replace hasText check with notNull for ApiKey with String value Signed-off-by: Ilayaperumal Gopinathan <[email protected]>
ilayaperumalg
force-pushed
the
openai-api-builder-changes
branch
from
795964f to
89dd0e4
Compare
|
This is merged as a528253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.