Skip to content

Deprecate redundant field in ModelObservationContext #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Deprecate redundant field in ModelObservationContext #2227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...re/src/main/java/org/springframework/ai/chat/observation/ChatModelObservationContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ public static Builder builder() {
return new Builder();
}

/**
* @deprecated Use {@link #getRequest().getOptions()} instead.
*/
@Deprecated(forRemoval = true)
public ChatOptions getRequestOptions() {
return this.requestOptions;
}
Expand All @@ -70,6 +74,11 @@ public Builder provider(String provider) {
return this;
}

/**
* @deprecated ChatOptions are passed in the Prompt object and should not be set
* separately anymore.
*/
@Deprecated(forRemoval = true)
public Builder requestOptions(ChatOptions requestOptions) {
this.requestOptions = requestOptions;
return this;
Expand Down
9 changes: 9 additions & 0 deletions ...n/java/org/springframework/ai/embedding/observation/EmbeddingModelObservationContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,10 @@ public static Builder builder() {
return new Builder();
}

/**
* @deprecated Use {@link #getRequest().getOptions()} instead.
*/
@Deprecated(forRemoval = true)
public EmbeddingOptions getRequestOptions() {
return this.requestOptions;
}
Expand All @@ -74,6 +78,11 @@ public Builder provider(String provider) {
return this;
}

/**
* @deprecated EmbeddingOptions are passed in the EmbeddingRequest object and
* should not be set separately anymore.
*/
@Deprecated(forRemoval = true)
public Builder requestOptions(EmbeddingOptions requestOptions) {
this.requestOptions = requestOptions;
return this;
Expand Down
9 changes: 9 additions & 0 deletions .../src/main/java/org/springframework/ai/image/observation/ImageModelObservationContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,10 @@ public static Builder builder() {
return new Builder();
}

/**
* @deprecated Use {@link #getRequest().getOptions()} instead.
*/
@Deprecated(forRemoval = true)
public ImageOptions getRequestOptions() {
return this.requestOptions;
}
Expand Down Expand Up @@ -74,6 +78,11 @@ public Builder provider(String provider) {
return this;
}

/**
* @deprecated ImageOptions are passed in the ImagePrompt object and should not be
* set separately anymore.
*/
@Deprecated(forRemoval = true)
public Builder requestOptions(ImageOptions requestOptions) {
this.requestOptions = requestOptions;
return this;
Expand Down