Skip to content

Conversation

@jaeyeonling
Copy link
Contributor

Changes

  • Use openAIClientBuilder instead of directly creating OpenAIClient.
  • Update AzureOpenAiChatModel instantiation to use openAIClientBuilder.
  • Remove unnecessary this. references.
  • Rename response to streamingResponses to avoid variable name duplication and improve clarity.

.build();
var chatModel = new AzureOpenAiChatModel(this.openAIClient, this.openAIChatOptions);
var chatModel = new AzureOpenAiChatModel(openAIClientBuilder, openAIChatOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this constructor method is deprecated and will be removed, I will update this to use the builder instead when merging.

@ilayaperumalg
Copy link
Member

@jaeyeonling Thanks for the PR!

@ilayaperumalg ilayaperumalg self-assigned this Feb 27, 2025
@ilayaperumalg ilayaperumalg added this to the 1.0.0-M7 milestone Feb 27, 2025
@ilayaperumalg ilayaperumalg added azure documentation Improvements or additions to documentation labels Feb 27, 2025
@ilayaperumalg
Copy link
Member

@jaeyeonling Rebased, updated the doc to use the builder and pushed the changes as 6cb15e4

@jaeyeonling
Copy link
Contributor Author

@ilayaperumalg Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

azure documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants