Migrate vector store auto-configurations to dedicated modules #2308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobychacko
force-pushed
the
vector-store-autoconfiguration
branch
from
95c2cd2 to
deb631f
Compare
|
After the rebase with Qdrant client update, I see that the Qdrant autoconfiguration needs to be updated as I see: [ERROR] /Users/igopinathan/dev/git/spring-projects/spring-ai/auto-configurations/vector-stores/spring-ai-qdrant-store-spring-boot-autoconfigure/src/main/java/org/springframework/ai/autoconfigure/vectorstore/qdrant/QdrantVectorStoreAutoConfiguration.java:[59,78] cannot access io.grpc.ManagedChannel |
sobychacko
force-pushed
the
vector-store-autoconfiguration
branch
2 times, most recently
from
806da0c to
778c890
Compare
Move vector store auto-configuration classes to dedicated modules under auto-configurations/vector-stores/: - Creates separate modules for Milvus, Pinecone, Qdrant, and Typesense vector stores - Moves CommonVectorStoreProperties to spring-ai-core for better reusability - Updates pom.xml dependencies to maintain proper relationships between modules - Name the artifacts based on the pattern spring-ai-autoconfigure-vectorestore-<implementation>. For example - spring-ai-autoconfigure-vectorestore-milvus - Package names follow the pattern org.springframework.ai.vectorstore.<implementation>.autoconfigure This change improves modularity by allowing each vector store implementation to be independently versioned and maintained, continuing the migration pattern established with previous vector stores. Signed-off-by: Soby Chacko <[email protected]>
sobychacko
force-pushed
the
vector-store-autoconfiguration
branch
from
778c890 to
c9d02ca
Compare
|
The starter POM artifact ID names need to be changed as well. |
| <version>1.0.0-SNAPSHOT</version> | ||
| <relativePath>../../../pom.xml</relativePath> | ||
| </parent> | ||
| <artifactId>spring-ai-autoconfigure-vectorstore-milvus</artifactId> |
There was a problem hiding this comment.
This needs to be "spring-ai-autoconfigure-vector-store-milvus" - "vector-store" instead of "vectorstore"
|
Closing this PR because of this updated one: #2386 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move vector store auto-configuration classes to dedicated modules under auto-configurations/vector-stores/:
This change improves modularity by allowing each vector store implementation to be independently versioned and maintained, continuing the migration pattern established with previous vector stores.