Add AssistantPromptTemplate override method createMessage() #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ZhangQin <[email protected]>
FormatToday
changed the title
|
Yikes, it is a bug. Great catch, it will be part of 0.8.0. Waiting for a long lived branch/PR to be merged in first. |
I'm really thrilled because my pull request got merged into a well-known open-source project for the first time. |
|
Now it is merged, time to party! 🥳 Merged in c1d3034 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when using the project, the
MessageTypeis stillUSERinstead of the expectedASSISTANTwhen usingAssistantPromptTemplate.I'm not sure if this issue is an oversight, a bug, or intentional. Therefore, I submitted this PR. If it's not an oversight or bug, please close the PR.