feat: Add equals, hashCode, deep copy, and tests to OCICohereChatOptions #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enhances OCICohereChatOptions by: - Updating equals and hashCode methods for proper object comparison. - Updating copy() method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state. - Adding OCICohereChatOptionsTests to verify copy(), builders, setters, and default values. Signed-off-by: Alexandros Pappas <[email protected]>
ThomasVitale
approved these changes
Apr 26, 2025
|
@apappascs thanks for your contribution! |
|
@apappascs Thanks for the PR! |
namsoo2
pushed a commit
to namsoo2/spring-ai
that referenced
this pull request
Jun 9, 2025
…ons (spring-projects#2361) This commit enhances OCICohereChatOptions by: - Updating equals and hashCode methods for proper object comparison. - Updating copy() method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state. - Adding OCICohereChatOptionsTests to verify copy(), builders, setters, and default values. Signed-off-by: Alexandros Pappas <[email protected]> Signed-off-by: minsoo.nam <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
…ons (spring-projects#2361) This commit enhances OCICohereChatOptions by: - Updating equals and hashCode methods for proper object comparison. - Updating copy() method, creating new instances of mutable collections (List, Set, Map, Metadata) to prevent shared state. - Adding OCICohereChatOptionsTests to verify copy(), builders, setters, and default values. Signed-off-by: Alexandros Pappas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances OCICohereChatOptions by: