optimize: use already defined variables #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yuluo-yx <[email protected]>
Contributor
|
The log shows the following Run `spring-javaformat:apply` to fix. |
Contributor
Author
|
I run
|
Contributor
|
The github action logs show that there is a problem with OpenAiChatModel.java and when I test it locally, the change occurs at line 199
(But I think the left side is cleaner.) |
Contributor
Author
|
yep, me too. emm~ I will try to fix. |
Signed-off-by: yuluo-yx <[email protected]>
Member
|
@yuluo-yx Thanks for the code cleanup! |
leijendary
pushed a commit
to leijendary/spring-ai
that referenced
this pull request
Mar 28, 2025
* optimize: use already defined variables Signed-off-by: yuluo-yx <[email protected]>
chedim
pushed a commit
to couchbaselabs/spring-ai
that referenced
this pull request
Sep 19, 2025
* optimize: use already defined variables Signed-off-by: yuluo-yx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimize: use already defined variables