extract onFinishReason() method #2500
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 0ad59e4) Signed-off-by: ghdcksgml1 <[email protected]>
(cherry picked from commit a4dc130) Signed-off-by: ghdcksgml1 <[email protected]>
Signed-off-by: ghdcksgml1 <[email protected]> (cherry picked from commit cb11592) Signed-off-by: ghdcksgml1 <[email protected]>
Signed-off-by: ghdcksgml1 <[email protected]>
|
sorry. I applied spring javaformat. |
|
@ghdcksgml1 No problem, thanks for the PR! Rebased, squashed and merged as e4357ba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I would like to propose a refactoring.
While working on
CustomAdvisor, I found that theonFinishReason()method could be extracted into a utility class.This method is particularly useful when implementing
StreamAroundAdvisor, as it helps determine whether the stream has finished.Copying and using this method every time we implement
CustomAdvisorseems quite cumbersome.How about extracting it into a utility class?
Thank you.