Skip to content

Conversation

@YunKuiLu
Copy link
Contributor

@YunKuiLu YunKuiLu commented Apr 15, 2025

Fixes GH-2743 (#2743)

Revised the following files to ensure accuracy:

  • openai-chat.adoc
  • openai-embeddings.adoc
  • usage-handling.adoc

Fixes #2743

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@YunKuiLu YunKuiLu changed the title GH-2743: Add Contribution Guidelines GH-2743: Correct erroneous content within the document Apr 15, 2025
Fixes spring-projectsGH-2743 (spring-projects#2743)

Revised the following files to ensure accuracy:
- `openai-chat.adoc`
- `openai-embeddings.adoc`
- `usage-handling.adoc`

Fixes spring-projects#2743

Signed-off-by: YunKui Lu <[email protected]>
@YunKuiLu YunKuiLu changed the title GH-2743: Correct erroneous content within the document GH-2743: Correct erroneous content in documents Apr 16, 2025
@YunKuiLu
Copy link
Contributor Author

Hi @ilayaperumalg, could you please help review this PR when you have time? Thanks!

@ilayaperumalg ilayaperumalg self-assigned this Apr 29, 2025
@ilayaperumalg ilayaperumalg added the documentation Improvements or additions to documentation label Apr 29, 2025
@ilayaperumalg ilayaperumalg added this to the 1.0.0-M8 milestone Apr 29, 2025
@ilayaperumalg
Copy link
Member

@YunKuiLu Thanks for the PR fixing the documentation!

@ilayaperumalg ilayaperumalg merged commit 4a62081 into spring-projects:main Apr 29, 2025
2 checks passed
@YunKuiLu YunKuiLu deleted the GH-2743 branch May 1, 2025 13:39
namsoo2 pushed a commit to namsoo2/spring-ai that referenced this pull request Jun 9, 2025
…g-projects#2744)

Fixes spring-projectsGH-2743 (spring-projects#2743)

Revised the following files to ensure accuracy:
- `openai-chat.adoc`
- `openai-embeddings.adoc`
- `usage-handling.adoc`

Fixes spring-projects#2743

Signed-off-by: YunKui Lu <[email protected]>
Signed-off-by: minsoo.nam <[email protected]>
chedim pushed a commit to couchbaselabs/spring-ai that referenced this pull request Sep 19, 2025
…g-projects#2744)

Fixes spring-projectsGH-2743 (spring-projects#2743)

Revised the following files to ensure accuracy:
- `openai-chat.adoc`
- `openai-embeddings.adoc`
- `usage-handling.adoc`

Fixes spring-projects#2743

Signed-off-by: YunKui Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Correct erroneous content within the document

2 participants