Inner advisor should handle output format instructions #2963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output format instructions should not be included until the very last advisor runs, otherwise there's a risk of templating failure if more than one advisor tries to render the prompt template. This change guarantees the output format instructions are always included right before calling the chat model, without the risk of previous advisors interfering with it. Signed-off-by: Thomas Vitale <[email protected]>
ThomasVitale
commented
May 1, 2025
| @Deprecated // Only for backward compatibility until the next release. | ||
| CHAT_MODEL("spring.ai.chat.client.model"), | ||
| @Deprecated // Only for backward compatibility until the next release. | ||
| OUTPUT_FORMAT("spring.ai.chat.client.output.format"), |
There was a problem hiding this comment.
Not a great approach using the advisor context for this, but we might re-evaluate later when considering the new structured output support.
ThomasVitale
commented
May 1, 2025
| } | ||
|
|
||
| @Test | ||
| void qaOutputConverter() { |
There was a problem hiding this comment.
This test case fails if we remove the change in DefaultChatClient. Unfortunately we didn't have any integration test combining output converter with advisors.
|
added a simple test with streaming - though we may have it elsewhere... merged in 90cab21 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output format instructions should not be included until the very last advisor runs, otherwise there's a risk of templating failure if more than one advisor tries to render the prompt template. This change guarantees the output format instructions are always included right before calling the chat model, without the risk of previous advisors interfering with it.